Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Device Support #31

Merged
merged 38 commits into from Oct 8, 2019
Merged

Multi Device Support #31

merged 38 commits into from Oct 8, 2019

Conversation

nielsandriesse
Copy link

No description provided.

@nielsandriesse nielsandriesse changed the title Multi Device Multi Device Support Oct 7, 2019
@Mikunj Mikunj closed this Oct 7, 2019
@Mikunj Mikunj reopened this Oct 7, 2019
@Mikunj Mikunj marked this pull request as ready for review October 7, 2019 01:25

fun handleDeviceLinkAuthorized() // TODO: Device link
fun handleDeviceLinkingDialogDismissed()
interface DeviceLinkingViewDelegate: DeviceLinkingDialogDelegate {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?????

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setup is now really weird

registerOrRestoreButton.setOnClickListener { registerOrRestore() }
Analytics.shared.track("Seed Screen Viewed")
}

override fun onDestroy() {
super.onDestroy()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, this was when i was still thinking about where to put the logic, we can remove this.

toggleModeButton.setOnClickListener { toggleMode() }
toggleRestoreModeButton.setOnClickListener { mode = Mode.Restore }
toggleRegisterModeButton.setOnClickListener { mode = Mode.Register }
toggleLinkModeButton.setOnClickListener { mode = Mode.Link }
registerOrRestoreButton.setOnClickListener { registerOrRestore() }
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does more than register or restore now

@nielsandriesse nielsandriesse merged commit 7116f25 into dev Oct 8, 2019
@nielsandriesse nielsandriesse deleted the multi-device branch October 8, 2019 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants